Skip to content

Feat/empty array optimisation bugfix #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Feat/empty array optimisation bugfix #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9273c89
fixing bug with extra empty array
Oct 25, 2024
61fe22b
4.1.16
Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/make/optimize-join-and-where.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ function extractNestedMatches(matches) {
const value = matches[orIndex];
ors.push(value);
}
const combined = ands.concat(orIndexes).sort((a, b) => b - a);
const combined = andIndexes.concat(orIndexes).sort((a, b) => b - a);
for (const index of combined) {
matches.splice(index, 1);
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@synatic/noql",
"version": "4.1.15",
"version": "4.1.16",
"description": "Convert SQL statements to mongo queries or aggregates",
"main": "index.js",
"files": [
Expand Down
3 changes: 3 additions & 0 deletions test/bug-fix-tests/bug-fix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,5 +1070,8 @@
}
]
}
},
"and-or-nor": {
"case-1": {}
}
}
Loading
Loading