Fix for join condition without aliases

lib/make/makeJoinForPipeline.js

@@ -322,7 +322,9 @@ function tableJoin(
         ? `${localPart.schema ? localPart.schema + '.' : ''}${
               localPart.table
           }.${localPart.column}`
-        : `${previousJoin.as || previousJoin.table}.${localPart.column}`;
+        : previousJoin.as
+          ? `${previousJoin.as}.${localPart.column}`
+          : localPart.column;
     const foreignField = fromPart.column;
     pipeline.push({
         $lookup: {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@synatic/noql",
-  "version": "4.1.14",
+  "version": "4.1.15",
   "description": "Convert SQL statements to mongo queries or aggregates",
   "main": "index.js",
   "files": [

test/aggregateTests/joins.json

@@ -49,7 +49,7 @@
           "$lookup": {
             "from": "inventory",
             "as": "inventory",
-            "localField": "orders.item",
+            "localField": "item",
             "foreignField": "sku"
           }
         },

test/joins/join-cases.json

@@ -916,6 +916,24 @@
           "i": []
         }
       ]
+    },
+    "no-alias": {
+      "case-1": {
+        "expectedResults": [
+          {
+            "item": "almonds",
+            "sku": [
+              "almonds"
+            ]
+          },
+          {
+            "item": "pecans",
+            "sku": [
+              "pecans"
+            ]
+          }
+        ]
+      }
     }
   },
   "n-level-join": {

test/joins/joins.test.js

@@ -194,6 +194,27 @@ describe('joins', function () {
                 casePath: 'left-join.basic-reversed',
             });
         });
+
+        it('should not need table aliases', async () => {
+            const queryString = `
+                select  item,
+                        inventory.sku
+                from
+                    \`orders\`
+                left outer JOIN \`inventory\` on \`inventory\`.\`sku\` =  \`item\`
+                LIMIT 2
+                `;
+            const {pipeline, results} = await queryResultTester({
+                queryString,
+                casePath: 'left-join.no-alias.case-1',
+                mode: 'write',
+                skipDbQuery: false,
+            });
+            const lookup = pipeline.find((p) => !!p.$lookup);
+            for (const result of results) {
+                assert.deepEqual(result.item, result.sku[0]);
+            }
+        });
     });
 
     describe('join order of queries', () => {