NoDynamicNameRule: Fix union type handling #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
approved these changes
Apr 7, 2025
|
Thank you 👍 |
staabm
commented
Apr 7, 2025
Comment on lines
-23
to
-27
| if ($unwrappedNameStaticType instanceof CallableType) { | ||
| return true; | ||
| } | ||
|
|
||
| if ($unwrappedNameStaticType instanceof ClosureType) { |
There was a problem hiding this comment.
cases and code like this is the main reason why instanceof on Type is bad practice and discouraged
There was a problem hiding this comment.
Depends. We have the exact opposite experience on many Rector rules. The ->is*() method have different behavior and are more tolerant, not 100 % reliable.
|
ahh nice, thanks for the fast merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.