Rename RemoveSetterGetterDocblockFixer to RemoveMethodNameDuplicateDescriptionFixer
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add "ClassMethod" to the name? We already have similar rule for classes, so we avoid mixing them up |
|
Hm since in PHP “method” really means “function in a class” WDYT of |
|
Sure :) 👍 |
|
One last note, instead of ambiguous "redundant", it would be better something "name-based" or "method-name-duplicate". This rule only removes docblocks that are equal to the method name 👍 |
|
|
…eDescriptionFixer`
MatTheCat
changed the title
RemoveSetterGetterDocblockFixer to RemoveRedundantDescriptionFixerRemoveSetterGetterDocblockFixer to RemoveMethodNameDuplicateDescriptionFixer
TomasVotruba
approved these changes
May 5, 2025
|
Awesome, thank you for the changes 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65