[Map] Add Rectangle support #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
||||||||||||||||||||||||||||||
Valmonzo
force-pushed
the
feat/add-rectangle-support-for-map
branch
2 times, most recently
from
e0b3f91 to
e76d201
Compare
carsonbot
added
Feature
Kocal
reviewed
Jun 21, 2025
Kocal
force-pushed
the
feat/add-rectangle-support-for-map
branch
from
dd132b1 to
861c5c9
Compare
Co-authored-by: Hugo Alliaume <hugo@alliau.me>
…mputing `@id` is expected
…r `Circle` and `Rectangle` instances
Kocal
force-pushed
the
feat/add-rectangle-support-for-map
branch
from
861c5c9 to
93c31b0
Compare
Kocal
reviewed
Jun 22, 2025
Comment on lines
+111
to
+118
| foreach ($attrs['circles'] as $key => $circle) { | ||
| $attrs['circles'][$key]['@id'] = $computeId($circle); | ||
| } | ||
|
|
||
| foreach ($attrs['rectangles'] as $key => $rectangle) { | ||
| $attrs['rectangles'][$key]['@id'] = $computeId($rectangle); | ||
| } | ||
|
|
There was a problem hiding this comment.
The @id computation was missing from last PR and this one, it was not possible to use them correctly when using the Map with a LiveComponent.
I've improved our tests to assert that @id are present and nicely computed, for the next Elements instances properties.
Kocal
reviewed
Jun 22, 2025
There was a problem hiding this comment.
Modifying this file was also forgotten in the previous PR and this one. Without these modifications, it was not possible to use <twig:ux:map circles="{{ ... }}"> or ux_map(circles=[]). Same for rectangles.
Kocal
approved these changes
Jun 22, 2025
carsonbot
added
Status: Reviewed
|
Thank you @Valmonzo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new
Rectangleelement to Map following GoogleMaps and Leaflet features.