Skip to content

[Icons] Docs: Deleting "search" codeblock #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

Q A
Bug fix? no
New feature? no
Docs? yes
Issues
License MIT

Page: https://symfony.com/bundles/ux-icons/current/index.html#search-icon-sets

Reasons:

  • I don't think that somebody will search for icons in a terminal window (i.e. without preview).
  • If somebody wants after all, the command is shown at the end of the previous code block.

Page: https://symfony.com/bundles/ux-icons/current/index.html#search-icon-sets

Reasons:
* I don't think that somebody will search for icons in a terminal window (i.e. without preview).
* If somebody wants after all, the command is shown at the end of the previous code block.
@carsonbot carsonbot added Icons Status: Needs Review Needs to be reviewed labels May 28, 2025
@ThomasLandauer ThomasLandauer changed the title [Icons] Docs: Deleting "search" coldeblock [Icons] Docs: Deleting "search" codeblock May 28, 2025
@smnandre
Copy link
Member

You'd be surprised.. :)

It is a feature, discussed here / on Slack more than once, and I do not see how removing this paragraph would improve the page in any way to be honest.

So it's 👎 for me here.

@ThomasLandauer
Copy link
Contributor Author

Ping @javiereguiluz WDYT?

@javiereguiluz
Copy link
Member

I don't use this frequently myself ... but I've used it with icon sets that I know well (e.g. Tabler). I don't have to look at the icons before downloading them. I just need to find the exact right name for it.

But for icon sets I don't know, I'd prefer to check the icons first. So, I'd say that it's worth mentioning it even if probably it's not a super popular feature.

@ThomasLandauer
Copy link
Contributor Author

My point is that the command itself (php bin/console ux:icons:search tabler arrow) is shown in the previous code block anyway. So IMO there's no need to show the full output of that command too.

@smnandre
Copy link
Member

php bin/console ux:icons:search tabler arrow

This is not the same results / usage.


I'm closing here as help is very much welcomed on the UX documentation..
... but deleting parts of it or "un-documenting" features is not something we have any desire right now.

Hope you understand.

@smnandre smnandre closed this May 29, 2025
@ThomasLandauer
Copy link
Contributor Author

This is not the same results / usage.

What do you mean is not the same?:

Screenshot_20250530_004350

@smnandre
Copy link
Member

The previous paragraph is called "Search Icon Sets".

This one is called "Search Icons". People access it while reading (sometimes in diagonal) or .. by clicking on the table of content. So no, the fact the previous command result ends with "php bin/..." is not enough to remove any interest about this one.

It's very clear to me "search icons" is a very decisive feature, for a "icons" package.. so keeping a paragraph on how to do it and what to expect from it is not something we would want to do.

And I still don't see how removing content from the documentation will help any user IRL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icons Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants