Skip to content

[Map] Remove invalid marker icon example #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented May 25, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

This icon example is invalid and is better described under "Add marker icons".

@dannyvw dannyvw requested a review from Kocal as a code owner May 25, 2025 11:55
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Bug Bug Fix Map labels May 25, 2025
@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@Kocal
Copy link
Member

Kocal commented May 26, 2025

Oh, thanks, I forgot this example when working on Marker icons.

@Kocal Kocal added docs Improvements or additions to documentation and removed Bug Bug Fix labels May 26, 2025
@Kocal
Copy link
Member

Kocal commented May 26, 2025

Thank you @dannyvw.

@Kocal Kocal merged commit 2b2d180 into symfony:2.x May 26, 2025
2 checks passed
@dannyvw dannyvw deleted the map-marker-icon-docs branch May 26, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Map Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants