-
-
Notifications
You must be signed in to change notification settings - Fork 364
Homogenize PHP-CS-Fixer configuration with symfony/symfony, and run it #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kocal
commented
May 23, 2025
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
Docs? | no |
Issues | Fix #... |
License | MIT |
Interesting, because PHP-CS-Fixer changed:
for:
The following error now happens:
That's weird, I would expect |
cf1862a
to
b150af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, always some troubles with anonymous classes in test & php-cs-fixer ..
For the rest, thanks!
b150af3
to
4f44267
Compare
Thanks for the review @smnandre 🙏🏻 it should be better now! |
.php-cs-fixer.dist.php
Outdated
|
||
return (new PhpCsFixer\Config()) | ||
->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect()) | ||
->setRules([ | ||
'@PHP71Migration' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need this addition ?
4f44267
to
8c1cdf4
Compare
8c1cdf4
to
cefa074
Compare