Add PHP types to private methods and functions

Author: wouterj

Data/Generator/AbstractDataGenerator.php

@@ -36,7 +36,7 @@ public function __construct(BundleCompilerInterface $compiler, string $dirName)
         $this->dirName = $dirName;
     }
 
-    public function generateData(GeneratorConfig $config)
+    public function generateData(GeneratorConfig $config): void
     {
         $filesystem = new Filesystem();
         $localeScanner = new LocaleScanner();

Data/Generator/CurrencyDataGenerator.php

@@ -53,13 +53,13 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $scanner->scanLocales($sourceDir.'/curr');
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $compiler->compile($sourceDir.'/curr', $tempDir);
         $compiler->compile($sourceDir.'/misc/currencyNumericCodes.txt', $tempDir);
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         $this->currencyCodes = [];
     }

Data/Generator/LanguageDataGenerator.php

@@ -103,13 +103,13 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $scanner->scanLocales($sourceDir.'/lang');
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $compiler->compile($sourceDir.'/lang', $tempDir);
         $compiler->compile($sourceDir.'/misc/metadata.txt', $tempDir);
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         $this->languageCodes = [];
     }

Data/Generator/RegionDataGenerator.php

@@ -67,7 +67,7 @@ class RegionDataGenerator extends AbstractDataGenerator
      */
     private array $regionCodes = [];
 
-    public static function isValidCountryCode(int|string|null $region)
+    public static function isValidCountryCode(int|string|null $region): bool
     {
         if (isset(self::DENYLIST[$region])) {
             return false;
@@ -86,13 +86,13 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $scanner->scanLocales($sourceDir.'/region');
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $compiler->compile($sourceDir.'/region', $tempDir);
         $compiler->compile($sourceDir.'/misc/metadata.txt', $tempDir);
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         $this->regionCodes = [];
     }

Data/Generator/ScriptDataGenerator.php

@@ -40,12 +40,12 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $scanner->scanLocales($sourceDir.'/lang');
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $compiler->compile($sourceDir.'/lang', $tempDir);
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         $this->scriptCodes = [];
     }

Data/Generator/TimezoneDataGenerator.php

@@ -46,7 +46,7 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $scanner->scanLocales($sourceDir.'/zone');
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $filesystem = new Filesystem();
         $filesystem->mkdir($tempDir.'/region');
@@ -57,7 +57,7 @@ protected function compileTemporaryBundles(BundleCompilerInterface $compiler, st
         $compiler->compile($sourceDir.'/misc/windowsZones.txt', $tempDir);
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         $this->zoneIds = [];
         $this->zoneToCountryMapping = [];

Data/Util/ArrayAccessibleResourceBundle.php

@@ -69,12 +69,12 @@ public function count(): int
         return $this->bundleImpl->count();
     }
 
-    public function getErrorCode()
+    public function getErrorCode(): int
     {
         return $this->bundleImpl->getErrorCode();
     }
 
-    public function getErrorMessage()
+    public function getErrorMessage(): string
     {
         return $this->bundleImpl->getErrorMessage();
     }