Add missing PHPdoc return types

wouterj · nicolas-grekas · commit b40fe004f212 · 2023-02-13T09:44:31.000+01:00
diff --git a/Resources/bin/common.php b/Resources/bin/common.php
@@ -24,13 +24,19 @@ function bailout(string $message)
     exit(1);
 }
 
+/**
+ * @return string
+ */
 function strip_minor_versions(string $version)
 {
     preg_match('/^(?P<version>[0-9]\.[0-9]|[0-9]{2,})/', $version, $matches);
 
     return $matches['version'];
 }
 
+/**
+ * @return string
+ */
 function centered(string $text)
 {
     $padding = (int) ((LINE_WIDTH - strlen($text)) / 2);
@@ -57,6 +63,9 @@ function run(string $command)
     }
 }
 
+/**
+ * @return string|null
+ */
 function get_icu_version_from_genrb(string $genrb)
 {
     exec($genrb.' --version - 2>&1', $output, $status);

Original file line number	Diff line number	Diff line change
`@@ -24,13 +24,19 @@ function bailout(string $message)`
`24`	`24`	`exit(1);`
`25`	`25`	`}`
`26`	`26`
	`27`	`+/**`
	`28`	`+ * @return string`
	`29`	`+ */`
`27`	`30`	`function strip_minor_versions(string $version)`
`28`	`31`	`{`
`29`	`32`	`preg_match('/^(?P<version>[0-9]\.[0-9]\|[0-9]{2,})/', $version, $matches);`
`30`	`33`
`31`	`34`	`return $matches['version'];`
`32`	`35`	`}`
`33`	`36`
	`37`	`+/**`
	`38`	`+ * @return string`
	`39`	`+ */`
`34`	`40`	`function centered(string $text)`
`35`	`41`	`{`
`36`	`42`	`$padding = (int) ((LINE_WIDTH - strlen($text)) / 2);`
`@@ -57,6 +63,9 @@ function run(string $command)`
`57`	`63`	`}`
`58`	`64`	`}`
`59`	`65`
	`66`	`+/**`
	`67`	`+ * @return string\|null`
	`68`	`+ */`
`60`	`69`	`function get_icu_version_from_genrb(string $genrb)`
`61`	`70`	`{`
`62`	`71`	`exec($genrb.' --version - 2>&1', $output, $status);`