Add void return types

Author: wouterj

Data/Bundle/Compiler/GenrbCompiler.php

@@ -43,7 +43,7 @@ public function __construct(string $genrb = 'genrb', string $envVars = '')
         $this->genrb = ($envVars ? $envVars.' ' : '').$genrb;
     }
 
-    public function compile(string $sourcePath, string $targetDir)
+    public function compile(string $sourcePath, string $targetDir): void
     {
         if (is_dir($sourcePath)) {
             $sourcePath .= '/*.txt';

Data/Bundle/Reader/BundleEntryReader.php

@@ -53,7 +53,7 @@ public function __construct(BundleReaderInterface $reader)
      *
      * @param array $localeAliases A mapping of locale aliases to locales
      */
-    public function setLocaleAliases(array $localeAliases)
+    public function setLocaleAliases(array $localeAliases): void
     {
         $this->localeAliases = $localeAliases;
     }

Data/Bundle/Writer/JsonBundleWriter.php

@@ -20,7 +20,7 @@
  */
 class JsonBundleWriter implements BundleWriterInterface
 {
-    public function write(string $path, string $locale, mixed $data)
+    public function write(string $path, string $locale, mixed $data): void
     {
         if ($data instanceof \Traversable) {
             $data = iterator_to_array($data);

Data/Bundle/Writer/PhpBundleWriter.php

@@ -20,7 +20,7 @@
  */
 class PhpBundleWriter implements BundleWriterInterface
 {
-    public function write(string $path, string $locale, mixed $data)
+    public function write(string $path, string $locale, mixed $data): void
     {
         $template = <<<'TEMPLATE'
 <?php

Data/Bundle/Writer/TextBundleWriter.php

@@ -26,7 +26,7 @@
  */
 class TextBundleWriter implements BundleWriterInterface
 {
-    public function write(string $path, string $locale, mixed $data, bool $fallback = true)
+    public function write(string $path, string $locale, mixed $data, bool $fallback = true): void
     {
         $file = fopen($path.'/'.$locale.'.txt', 'w');
 
@@ -43,7 +43,7 @@ public function write(string $path, string $locale, mixed $data, bool $fallback
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeResourceBundle($file, string $bundleName, mixed $value, bool $fallback)
+    private function writeResourceBundle($file, string $bundleName, mixed $value, bool $fallback): void
     {
         fwrite($file, $bundleName);
 
@@ -60,7 +60,7 @@ private function writeResourceBundle($file, string $bundleName, mixed $value, bo
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeResource($file, mixed $value, int $indentation, bool $requireBraces = true)
+    private function writeResource($file, mixed $value, int $indentation, bool $requireBraces = true): void
     {
         if (\is_int($value)) {
             $this->writeInteger($file, $value);
@@ -109,7 +109,7 @@ private function writeResource($file, mixed $value, int $indentation, bool $requ
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeInteger($file, int $value)
+    private function writeInteger($file, int $value): void
     {
         fprintf($file, ':int{%d}', $value);
     }
@@ -121,7 +121,7 @@ private function writeInteger($file, int $value)
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeIntVector($file, array $value, int $indentation)
+    private function writeIntVector($file, array $value, int $indentation): void
     {
         fwrite($file, ":intvector{\n");
 
@@ -139,7 +139,7 @@ private function writeIntVector($file, array $value, int $indentation)
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeString($file, string $value, bool $requireBraces = true)
+    private function writeString($file, string $value, bool $requireBraces = true): void
     {
         if ($requireBraces) {
             fprintf($file, '{"%s"}', $value);
@@ -157,7 +157,7 @@ private function writeString($file, string $value, bool $requireBraces = true)
      *
      * @see http://source.icu-project.org/repos/icu/icuhtml/trunk/design/bnf_rb.txt
      */
-    private function writeArray($file, array $value, int $indentation)
+    private function writeArray($file, array $value, int $indentation): void
     {
         fwrite($file, "{\n");
 
@@ -177,7 +177,7 @@ private function writeArray($file, array $value, int $indentation)
      *
      * @param resource $file The file handle to write to
      */
-    private function writeTable($file, iterable $value, int $indentation, bool $fallback = true)
+    private function writeTable($file, iterable $value, int $indentation, bool $fallback = true): void
     {
         if (!$fallback) {
             fwrite($file, ':table(nofallback)');

Data/Generator/GeneratorConfig.php

@@ -39,7 +39,7 @@ public function __construct(string $sourceDir, string $icuVersion)
     /**
      * Adds a writer to be used during the data conversion.
      */
-    public function addBundleWriter(string $targetDir, BundleWriterInterface $writer)
+    public function addBundleWriter(string $targetDir, BundleWriterInterface $writer): void
     {
         $this->bundleWriters[$targetDir] = $writer;
     }

Data/Generator/LocaleDataGenerator.php

@@ -42,7 +42,7 @@ protected function scanLocales(LocaleScanner $scanner, string $sourceDir): array
         return $this->locales;
     }
 
-    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir)
+    protected function compileTemporaryBundles(BundleCompilerInterface $compiler, string $sourceDir, string $tempDir): void
     {
         $filesystem = new Filesystem();
         $filesystem->mkdir([
@@ -53,7 +53,7 @@ protected function compileTemporaryBundles(BundleCompilerInterface $compiler, st
         $compiler->compile($sourceDir.'/region', $tempDir.'/region');
     }
 
-    protected function preGenerate()
+    protected function preGenerate(): void
     {
         // Write parents locale file for the Translation component
         file_put_contents(

Locale.php

@@ -34,7 +34,7 @@ final class Locale extends \Locale
      *
      * @see getFallback()
      */
-    public static function setDefaultFallback(?string $locale)
+    public static function setDefaultFallback(?string $locale): void
     {
         self::$defaultFallback = $locale;
     }

Resources/bin/common.php

@@ -44,14 +44,14 @@ function centered(string $text)
     return str_repeat(' ', $padding).$text;
 }
 
-function cd(string $dir)
+function cd(string $dir): void
 {
     if (false === chdir($dir)) {
         bailout("Could not switch to directory $dir.");
     }
 }
 
-function run(string $command)
+function run(string $command): void
 {
     exec($command, $output, $status);
 

Util/GitRepository.php

@@ -80,7 +80,7 @@ public function getLastTag(callable $filter = null): string
         return $this->getLastLine($tags);
     }
 
-    public function checkout(string $branch)
+    public function checkout(string $branch): void
     {
         $this->execInPath(sprintf('git checkout %s', escapeshellarg($branch)));
     }