Skip to content

Commit a66a4b2

Browse files
Merge branch '2.8' into 3.3
* 2.8: [FrameworkBundle] remove esi/ssi renderers if inactive
2 parents 932ddb2 + bbae2ab commit a66a4b2

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,8 @@ private function registerFormConfiguration(array $config, ContainerBuilder $cont
362362
private function registerEsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
363363
{
364364
if (!$this->isConfigEnabled($container, $config)) {
365+
$container->removeDefinition('fragment.renderer.esi');
366+
365367
return;
366368
}
367369

@@ -371,6 +373,8 @@ private function registerEsiConfiguration(array $config, ContainerBuilder $conta
371373
private function registerSsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
372374
{
373375
if (!$this->isConfigEnabled($container, $config)) {
376+
$container->removeDefinition('fragment.renderer.ssi');
377+
374378
return;
375379
}
376380

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,31 @@ public function testEsi()
131131
$container = $this->createContainerFromFile('full');
132132

133133
$this->assertTrue($container->hasDefinition('esi'), '->registerEsiConfiguration() loads esi.xml');
134+
$this->assertTrue($container->hasDefinition('fragment.renderer.esi'));
135+
}
136+
137+
public function testEsiInactive()
138+
{
139+
$container = $this->createContainerFromFile('default_config');
140+
141+
$this->assertFalse($container->hasDefinition('fragment.renderer.esi'));
142+
$this->assertFalse($container->hasDefinition('esi'));
134143
}
135144

136145
public function testSsi()
137146
{
138147
$container = $this->createContainerFromFile('full');
139148

140149
$this->assertTrue($container->hasDefinition('ssi'), '->registerSsiConfiguration() loads ssi.xml');
150+
$this->assertTrue($container->hasDefinition('fragment.renderer.ssi'));
151+
}
152+
153+
public function testSsiInactive()
154+
{
155+
$container = $this->createContainerFromFile('default_config');
156+
157+
$this->assertFalse($container->hasDefinition('fragment.renderer.ssi'));
158+
$this->assertFalse($container->hasDefinition('ssi'));
141159
}
142160

143161
public function testEnabledProfiler()

0 commit comments

Comments
 (0)