Skip to content

Commit bbae2ab

Browse files
Merge branch '2.7' into 2.8
* 2.7: [FrameworkBundle] remove esi/ssi renderers if inactive
2 parents be7fdff + 30f99b0 commit bbae2ab

File tree

2 files changed

+22
-0
lines changed

2 files changed

+22
-0
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,8 @@ private function registerFormConfiguration(array $config, ContainerBuilder $cont
217217
private function registerEsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
218218
{
219219
if (!$this->isConfigEnabled($container, $config)) {
220+
$container->removeDefinition('fragment.renderer.esi');
221+
220222
return;
221223
}
222224

@@ -226,6 +228,8 @@ private function registerEsiConfiguration(array $config, ContainerBuilder $conta
226228
private function registerSsiConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
227229
{
228230
if (!$this->isConfigEnabled($container, $config)) {
231+
$container->removeDefinition('fragment.renderer.ssi');
232+
229233
return;
230234
}
231235

Tests/DependencyInjection/FrameworkExtensionTest.php

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,31 @@ public function testEsi()
9797
$container = $this->createContainerFromFile('full');
9898

9999
$this->assertTrue($container->hasDefinition('esi'), '->registerEsiConfiguration() loads esi.xml');
100+
$this->assertTrue($container->hasDefinition('fragment.renderer.esi'));
101+
}
102+
103+
public function testEsiInactive()
104+
{
105+
$container = $this->createContainerFromFile('default_config');
106+
107+
$this->assertFalse($container->hasDefinition('fragment.renderer.esi'));
108+
$this->assertFalse($container->hasDefinition('esi'));
100109
}
101110

102111
public function testSsi()
103112
{
104113
$container = $this->createContainerFromFile('full');
105114

106115
$this->assertTrue($container->hasDefinition('ssi'), '->registerSsiConfiguration() loads ssi.xml');
116+
$this->assertTrue($container->hasDefinition('fragment.renderer.ssi'));
117+
}
118+
119+
public function testSsiInactive()
120+
{
121+
$container = $this->createContainerFromFile('default_config');
122+
123+
$this->assertFalse($container->hasDefinition('fragment.renderer.ssi'));
124+
$this->assertFalse($container->hasDefinition('ssi'));
107125
}
108126

109127
public function testEnabledProfiler()

0 commit comments

Comments
 (0)