Fix label spacing in PR titles #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added multiple test cases to ensure labels are always concatenated without spaces between brackets. These tests verify the correct behavior in various scenarios including incremental label additions and empty titles.
OskarStark
force-pushed
the
fix-label-spacing-in-titles
branch
from
24f7495 to
9c7dac8
Compare
This test was overly complex and didn't test anything that wasn't already covered by other simpler tests.
|
Hmm all the tests are passing |
|
Do you have an example PR where this is not working as expected? |
When a title contains bracketed text like [Foo] that isn't a recognized label, and a real label is added, ensure all brackets are concatenated without spaces. For example, adding 'Platform' label to '[Foo] Bar' now produces '[Platform][Foo] Bar' instead of '[Platform] [Foo] Bar'. - Extract and preserve bracketed text at the beginning of titles - Concatenate all brackets (labels and non-labels) without spaces - Add comprehensive test cases for mixed recognized/unrecognized brackets
|
Yes, add the While - [Platform] [OpenAi] Add GPT 5 models
+ [Platform][OpenAi] Add GPT 5 models |
OskarStark
commented
Aug 8, 2025
|
I see, I thought this could be related to some kind of non-breaking space, but that doesn't seem to be the case. |
Co-authored-by: Tobias Nyholm <tobias.nyholm@gmail.com>
alexandre-daubois
approved these changes
Aug 8, 2025
Kocal
approved these changes
Aug 8, 2025
xabbuh
reviewed
Aug 9, 2025
OskarStark
commented
Aug 9, 2025
|
Please fix the CS issues, then I would be happy to merge. |
xabbuh
reviewed
Aug 9, 2025
OskarStark
commented
Aug 9, 2025
- Remove trailing whitespace on blank lines - Add periods to PHPDoc summaries
Done |
Nyholm
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple labels are added to a PR, ensure they are concatenated without spaces between brackets