chore(phpstan): set level 8, fix issues + bump PHPStan CI version #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn... did not get these errors locally 😶🌫️ (will fix tomorrow) |
OskarStark
reviewed
Apr 29, 2025
OskarStark
reviewed
Apr 29, 2025
| private static array $labelAliases = [ | ||
| private const array LABEL_ALIASES = [ | ||
| 'bridge\doctrine' => 'DoctrineBridge', | ||
| 'bridge/doctrine' => 'DoctrineBridge', |
There was a problem hiding this comment.
DX ? Having 5 felt easier to read/maintain, but this was not really in the scope of the PR i must admit. Should i revert ?
There was a problem hiding this comment.
Just read the rest of the code, I think it's fine.
stof
reviewed
Apr 29, 2025
smnandre
changed the title
fabpot
approved these changes
May 12, 2025
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set PHPStan from
level 5tolevel 7level 8+ bump PHPStan to
2.1on the CI