-
Notifications
You must be signed in to change notification settings - Fork 31
Add support for symfony/webpack-encore-bundle
#248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f25dcca
to
2cd2420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Kocal Can you test this and confirm it work as expected? |
Thanks for merging! Let's try |
@fabpot it looks like it does not work:
I don't have access to WebpackEncoreBundle repo settings, so IDK about webhooks states. |
Not sure what's missing here. |
Fixed. I've also fixed webpack-encore which didn't work as well. |
I can see that the bot did its work, so we're good now. |
That's perfect, thanks! |
Like #237, but for https://github.com/symfony/webpack-encore-bundle.
For the time being, and given the state of the project, adding CarsonBot will be useful for notifying new-PR authors if maintainers can't modify their PR.
I also plan to add the PR template soon.
Things to do at post-merge:
SYMFONY_WEBPACK_ENCORE_BUNDLE_SECRET
environment variable in platform.shThanks