Skip to content

Add support for symfony/webpack-encore-bundle #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Oct 1, 2024

Like #237, but for https://github.com/symfony/webpack-encore-bundle.

For the time being, and given the state of the project, adding CarsonBot will be useful for notifying new-PR authors if maintainers can't modify their PR.
I also plan to add the PR template soon.

Things to do at post-merge:

  1. Add SYMFONY_WEBPACK_ENCORE_BUNDLE_SECRET environment variable in platform.sh
  2. Configure a webhook in https://github.com/symfony/webpack-encore-bundle

Thanks

@Kocal Kocal force-pushed the feat/webpack-encore-bundle branch from f25dcca to 2cd2420 Compare October 1, 2024 15:22
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabpot fabpot merged commit 2e4b6f4 into symfony-tools:master Mar 26, 2025
4 checks passed
@fabpot
Copy link
Contributor

fabpot commented Mar 26, 2025

@Kocal Can you test this and confirm it work as expected?

@Kocal
Copy link
Contributor Author

Kocal commented Mar 26, 2025

Thanks for merging!

Let's try

@Kocal
Copy link
Contributor Author

Kocal commented Mar 26, 2025

@fabpot it looks like it does not work:

  1. Minor improvements symfony/webpack-encore-bundle#181 (comment), I expect to see the label Status: Needs Review automatically added
  2. Testing Carson symfony/webpack-encore-bundle#241, I also expect labels Feature and Bug to be added

I don't have access to WebpackEncoreBundle repo settings, so IDK about webhooks states.

@fabpot
Copy link
Contributor

fabpot commented Mar 26, 2025

[2025-03-26T16:57:22.731780+00:00] app.ERROR: Failed dispatching "pull_request" event for "symfony/webpack-encore-bundle" repository. {"exception":"[object] (Github\\Exception\\RuntimeException(code: 403): Must have admin rights to Repository. at /app/vendor/knplabs/github-api/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php:137)"} []

Not sure what's missing here.

@fabpot
Copy link
Contributor

fabpot commented Mar 26, 2025

Fixed. I've also fixed webpack-encore which didn't work as well.

@fabpot
Copy link
Contributor

fabpot commented Mar 26, 2025

I can see that the bot did its work, so we're good now.

@Kocal
Copy link
Contributor Author

Kocal commented Mar 26, 2025

That's perfect, thanks!

@Kocal Kocal deleted the feat/webpack-encore-bundle branch March 26, 2025 21:10
@Kocal
Copy link
Contributor Author

Kocal commented Mar 27, 2025

😍

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants