[defaults] Fix void-function move-buffer-to-window #17131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't try to avoid defining various functions at top level if some package doesn't exist---it's fine for them to just error. - Replace soft message with a user-error. - Do not check whether the winum package is configured by Spacemacs. It is sufficient for the winum feature to be provided by a site-lisp package. - Fix up docstrings slightly, according to checkdoc. Fix syl20bnr#17130.
After 80a9502, this is no longer correct, because funcs.el must be loaded before packages are declared (as funcs.el may define functions that are used in :toggle form).
|
Pushed another commit to also fix a couple other places where The configuration layer is very complicated and stuff like this is why my branch for fixing #16346 got stalled :) |
fnussbaum
approved these changes
Sep 23, 2025
fnussbaum
added a commit
that referenced
this pull request
Sep 23, 2025
fnussbaum
added a commit
that referenced
this pull request
Sep 23, 2025
|
Thanks! I have pushed two minor related changes. |
|
Ah, good catch on the documentation especially :) |
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Oct 15, 2025
aam-at
pushed a commit
to aam-at/spacemacs
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to avoid defining various functions at top level if some
package doesn't exist---it's fine for them to just error.
Replace soft message with a user-error.
Do not check whether the winum package is configured by Spacemacs.
It is sufficient for the winum feature to be provided by a site-lisp
package.
Fix up docstrings slightly, according to checkdoc.
Fix #17130.
See also #17080.