[dotfile] Make defaults for dotspacemacs variables reflect template #17123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename test dotspacemacs.el to init.el, and use the test directory as SPACEMACSDIR (which will cause Spacemacs to automatically load $TEST_DIR/init.el as the dotspacemacs file and avoid reading the "real" ~/.spacemacs). Furthermore, use emacs -Q to avoid loading any site-lisp or site-start files. This change allows developers to easily run the tests and have correct behavior without going through the GitHub CI scripts (instead just running make locally).
De facto, the values for the various dotspacemacs-* variables default to whatever is in dotspacemacs-template.el. Make the actual default values (if the variables are not explicitly set by .spacemacs) match the user-facing defaults.
bcc32
force-pushed
the
match-defaults
branch
from
19717b6 to
3ef9a1d
Compare
fnussbaum
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De facto, the values for the various
dotspacemacs-*variablesdefault to whatever is in
dotspacemacs-template.el. Make the actualdefault values (if the variables are not explicitly set by
.spacemacs) match the user-facing defaults.In this PR, I also:
~/.spacemacs,so that their behavior does not depend on the running user.
core-dotspacemacs.elanddotspacemacs-template.elin sync. (This test starts out failinguntil the commit which fixes
core-dotspacemacs.el)