[editing-visual] Fix problems with term-cursor in daemon mode #16582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnussbaum
force-pushed
the
term-cursor-daemon-fix
branch
from
3af7283 to
58c4c26
Compare
Remove `lsp-ui-doc-frame-hook` from `term-cursor-triggers` to fix syl20bnr#15667. The hook is run with two arguments, but the handler function `term-cursor--immediate` does not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.) Also do not enable `global-term-cursor-mode` in daemon mode unless a terminal frame is created.
fnussbaum
force-pushed
the
term-cursor-daemon-fix
branch
from
58c4c26 to
4ac439a
Compare
smile13241324
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
lsp-ui-doc-frame-hookfromterm-cursor-triggersto fix #15667. The hook is run with two arguments, but the handler functionterm-cursor--immediatedoes not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.)Also do not enable
global-term-cursor-modein daemon mode unless a terminal frame is created.