Simplify scripts #45
Merged
Simplify scripts #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Ensure the fp, fn, tp gdf have the necessary columns so we don't have to check when calculating the metrics
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I found out that the saved global metrics where always computed with the macro-average method and I changed the code to make it dependant on the chosen method. |
clmarmy
requested changes
Mar 7, 2025
scripts/assess_detections.py
Outdated
| @@ -336,13 +336,13 @@ def main(cfg_file_path): | |||
| # we select the threshold which maximizes the f1-score on the val dataset | |||
| if 'val' in metrics_cl_df_dict.keys() and CONFIDENCE_THRESHOLD: | |||
| logger.error('The confidence score was determined over the val dataset, but a confidence score is given in the config file.') | |||
There was a problem hiding this comment.
"confidence threshold" and not "confidence score" ?
|
|
||
| if tested_seed == max_seed-1: | ||
| logger.warning(f'No satisfying seed found between 0 and {max_seed}.') | ||
| logger.info(f'The best seed was {seed} with ~{best_split} class subsets containing the correct proportion (trn~0.7, val~0.15, tst~0.15).') |
Analysis Details2 Issues
Coverage and Duplications
Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to simplify the tileset generation by dividing it into several scripts. Everything is called by the script
generate_tilesets.py, so the commands are still the same.I tested the result on the roads and border points. I did not check the functionality for FP and empty tiles and I would have to find some files to do so.