Adding more features #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+8
to
+15
| @property | ||
| def cve(self): | ||
| """ | ||
| return random selected CVE from thee file all_current_cves.txt | ||
| """ | ||
| with open("./socfaker/data/cves/all_current_cves.txt","r") as txtFile: | ||
| self.cves = txtFile.read().split("\n") | ||
| return self.random.choice(self.cves) |
There was a problem hiding this comment.
This should actually go in the vulnerability.py class as a new property (i think).
Comment on lines
+281
to
+291
|
|
||
| @property | ||
| def cves(self): | ||
| """Used to create a random CVE. | ||
| Returns: | ||
| cve: Returns an object with methods to generate a random CVE. | ||
| """ | ||
| from .cves import CVES | ||
| return CVES() | ||
|
|
There was a problem hiding this comment.
We should remove this and reference the property in the vulnerability class
Comment on lines
+292
to
+301
| @property | ||
| def ssdeep_hash(self): | ||
| """Used to create a random ssdeep hash. | ||
| Returns: | ||
| cve: Returns an object with method to generate a random ssdeep hash. | ||
| """ | ||
| from .cves import CVES | ||
| return CVES() | ||
|
|
There was a problem hiding this comment.
I think this should be (once complete) moved to the file.py with other hashes.
Comment on lines
+1
to
+15
| from .baseclass import BaseClass | ||
|
|
||
| class CVES(BaseClass): | ||
| """ | ||
| Randomly select CVE's from all_current_cves.txt | ||
| """ | ||
|
|
||
| @property | ||
| def cve(self): | ||
| """ | ||
| return random selected CVE from thee file all_current_cves.txt | ||
| """ | ||
| with open("./socfaker/data/cves/all_current_cves.txt","r") as txtFile: | ||
| self.cves = txtFile.read().split("\n") | ||
| return self.random.choice(self.cves) No newline at end of file |
There was a problem hiding this comment.
We should remove this class and add the ssdeep hash to the file.py class as another property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.