Skip to content

Timezone flexible, more tests, refactor main code #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Timezone flexible, more tests, refactor main code #10

wants to merge 14 commits into from

Conversation

@slabgorb
Copy link

@slabgorb slabgorb commented Jun 14, 2024 •
edited
Loading

  • Refactored main code, splitting out helper functions that made the code more testable
  • Additional tests
  • Moved function params into object initializer as properties
  • Made the calculate function recursive
  • added github actions to autorun pytests and ruff linter on push

slabgorb added 14 commits June 13, 2024 13:08
@slabgorb
fix: add .venv to gitignore
75c2108
@slabgorb
chore: bump pemdulum version for compatibility with python 3.12
b44583c
@slabgorb
refactor: use properties instead of passing in params each time
e106f85 
split functions a bit so we can test parts of the code at a time
add new tests
@slabgorb
refactor: refactor and split up functionality and tests. More explici…
5ab99f0 
…t tests.
@slabgorb
refactor: refactor and split up functionality and tests. More explici…
a45d95b 
…t tests.
@slabgorb
refactor: improve tests and improve signature of calculate (not backw…
8115f8f 
…ards compatible)
@slabgorb
workflows: add github workflows for ci/cd love
3c9c5f5
@slabgorb
workflow: fix for pytest not getting picked up
6fa591d
@slabgorb
feat: handle timezones explicitly, converting to and from the base sl…
f5352ea 
…a timezone for comapres
@slabgorb
workflow: change runs on to try to get pr agent to be picked up (may …
c50bc1d 
…be a API interruption)
@slabgorb
lint: remove print statements in tests
edb4db8
@slabgorb
Merge pull request #1 from 1898andCo/fix-tests
ff75116 
Fix tests
@slabgorb
docs: updated readme with new api
7a53a89
@slabgorb
Merge pull request #2 from 1898andCo/fix-tests
718e036 
docs: updated readme with new api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slabgorb