Host Platform arg and Fix for input.default not being iterable. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code would check if the platform was supported by atomic operator and by the test. if it wasn't it would throw an atomic operator platform support error because a test didn't support a platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the
--hostargument to accept a dictionary so now it'll look like--host '{"hostname":"platform"}'.Before, without selecting a platform, tests would possibly run multiple times due to running for how many supported platoforms there were in the test files.
For example, T1098.004 supported linux and macos, so it would run twice for each host provided. For this exact test, it isn't an issue, but could possibly be for other tests.
I also modified the code to check for the provided platform and only spit out test informaton if the platform was supported. Before, the cli would output all the GUIDs as empty dicts even for tests it wouldn't/couldn't run. This was mostly to clean up output.
I also added code to check a tests input argument type. There was an issue where it would try to replace the temp env variable if the executator was powershell. Some input args were ints and this would cause an error. So now, if the input.type isn't a path, then it won't try to do that. This kind of relates to #78 .
Finally, I updated some of the install instructions on the Readme to reflect current options for installing.