Skip to content

Bundler fixes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Bundler fixes #10

merged 1 commit into from
Apr 10, 2025

Conversation

andrewmd5
Copy link
Contributor

@andrewmd5 andrewmd5 commented Apr 9, 2025

This fixes some issues that cause esbuild to throw errors.

  • Exports have been moved to the right location in package.json
  • I removed the browser/node workaround for crypto; it should be the responsibility of the app to provide the method if 'crypto.getRandomValues' isn't the default.

typescript / bundlers expect things to be defined inside the exports definition

fix: node deps

fix: make app responsible for providing the implementation

chore: bump node
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit c175764 into swiftwasm:main Apr 10, 2025
1 check passed
@andrewmd5
Copy link
Contributor Author

Any chance you could publish a new release with these changes?

@kateinoigakukun
Copy link
Member

@andrewmd5 Just released it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants