Resolve the swiftly bin path #1632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was failing to compute the correct lldb-dap path because the user had pointed `swift.path` to `~/.swiftly/bin`. When resolving the path, lldb-dap path ends up being computed as `$PWD/lldb-dap`. To get around this, if we know the provided path is a swiftly bin directory, then resolve the correct swift path and toolchain path using built-in swiftly commands Issue: swiftlang#1619
cmcgee1024
reviewed
Jun 20, 2025
| let realSwift = await fs.realpath(swift); | ||
| if (path.basename(realSwift) === "swiftly") { | ||
| try { | ||
| const { stdout } = await execFile(realSwift, ["run", "which", "swift"]); |
There was a problem hiding this comment.
suggestion: If you know that this is swiftly based on the symlink, then you can use swiftly use --print-location and append usr/bin/swift to the end of that path. This will work on systems that don't have the which command, such as Windows, or a minimal Linux system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was failing to compute the correct lldb-dap path because the user had pointed
swift.pathto~/.swiftly/bin. When resolving the path, lldb-dap path ends up being computed as$PWD/lldb-dap. To get around this, if we know the provided path is a swiftly bin directory, then resolve the correct swift path and toolchain path using built-in swiftly commandsIssue: #1619