Refactor list command to support json format #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roulpriya
requested review from
shahmishal,
cmcgee1024,
justice-adams-apple and
etcwilde
as code owners
roulpriya
force-pushed
the
refactor-list-command
branch
from
9fc820b to
ae57fbc
Compare
cmcgee1024
reviewed
Jun 18, 2025
Tests/SwiftlyTests/ListTests.swift
Outdated
| List.self, ["list", "--format", "json"], format: .json | ||
| ) | ||
|
|
||
| let result = try JSONSerialization.jsonObject( |
There was a problem hiding this comment.
question: Instead of decoding this JSON data into a dictionary, why not decode into a InstalledToolchainsListInfo instead? The checks below would just be simple field accesses instead of dictionary lookups.
There was a problem hiding this comment.
Doing that forces us to implement Decodable in all the structs.
There was a problem hiding this comment.
Would it be much effort to make them Decodable?
There was a problem hiding this comment.
@cmcgee1024 refactored the tests to use decode the corresponding outputdata
cmcgee1024
reviewed
Jun 18, 2025
cmcgee1024
reviewed
Jun 18, 2025
roulpriya
force-pushed
the
refactor-list-command
branch
from
ae57fbc to
c739bf5
Compare
roulpriya
force-pushed
the
refactor-list-command
branch
from
c739bf5 to
c779021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #376
Refactor the List command to support JSON output format.