Find symlink managed swiftly when creating proxies #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
shahmishal,
justice-adams-apple and
etcwilde
as code owners
|
@swift-ci test macOS |
plemarquand
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swiftly is being invoked through a symlink, like what happens with
homebrew, then it should be able to create proxies that point to the swiftly
symlink that is on the path. That symlink is updated whenever swiftly is
upgraded in this environment.
Change the find swiftly binary code to account for this case and return
the absolute path to the swiftly symlink for proxy creation.