Build swiftly release cleanup #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model the pkgbuild command with the usual structure used for other commands. Provide a custom string convertible implementation for configuration so that the configuration can be easily converted into a string for logging and comparison purposes. Create a runEcho() implementation for the build swiftly release script so that commands can output their command-line to the log for reproducibility.
|
@swift-ci test macOS |
…d-swiftly-release-cleanup
Model locally shell command invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the copies of bits of SwiftlyCore functionality in the build-swiftly-release script:
Remove the curl dependency from the release script using the AsyncHTTPClient instead
to download libarchive.
Migrate the release script from URLs and FileManager to the new FilePath and FileSystem
component for improved readability, and type safety.