-
Notifications
You must be signed in to change notification settings - Fork 51
Add ability to temporarily unlink swiftly #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8cfcee
to
bfac041
Compare
f131884
to
ac4b473
Compare
cmcgee1024
reviewed
Apr 23, 2025
cmcgee1024
reviewed
Apr 23, 2025
cmcgee1024
reviewed
Apr 23, 2025
cmcgee1024
reviewed
Apr 24, 2025
cmcgee1024
reviewed
Apr 24, 2025
cmcgee1024
reviewed
Apr 24, 2025
cmcgee1024
reviewed
Apr 24, 2025
3555391
to
e076b0f
Compare
cmcgee1024
reviewed
Apr 29, 2025
cmcgee1024
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. There's just the merge conflicts (another PR to provide gentle update messages).
Adds two new commands, `swiftly unlink` and `swiftly link`, which will disable and reenable swiftly's management of the active toolchain. The `unlink` command removes the symlinks to toolchain binaries in the swiftly bin directory that is in the user's path. This allows the rest of the `$PATH` to be searched for available toolchain installations, falling back to the system default. On macOS with Xcode installed this has the effect of falling back to the toolchain in the user's installed Xcode. The `link` command reinstates the symlinks to the `inUse` toolchain, which allows swiftly to resume management of the active toolchain.
718b73f
to
7223dcb
Compare
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new commands,
swiftly unlink
andswiftly link
, which will disable and reenable swiftly's management of the active toolchain.The
unlink
command removes the symlinks to toolchain binaries in the swiftly bin directory that is in the user's path. This allows the rest of the$PATH
to be searched for available toolchain installations, falling back to the system default. On macOS with Xcode installed this has the effect of falling back to the toolchain in the user's installed Xcode.The
link
command reinstates the symlinks to theinUse
toolchain, which allows swiftly to resume management of the active toolchain.