Introduce type sugar for InlineArray #80087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
rintaro,
xymus,
AnthonyLatsis,
CodaFi,
DougGregor,
nkcsgexi,
adrian-prantl and
tshortli
as code owners
hamishknight
force-pushed
the
inline-array-type
branch
from
e5d793c to
bdc30de
Compare
hamishknight
force-pushed
the
inline-array-type
branch
from
bdc30de to
dcd4c72
Compare
xedin
reviewed
Mar 18, 2025
hamishknight
force-pushed
the
inline-array-type
branch
from
dcd4c72 to
68c461d
Compare
hamishknight
force-pushed
the
inline-array-type
branch
from
68c461d to
3d7f28b
Compare
ahoppen
approved these changes
Mar 19, 2025
Previously we would try the contextual type `(<int>, <element>)`, which is wrong. Given we want to eliminate shrink, let's just bail.
Make sure it's called for sugar code paths too. Also let's just always run it since it should be a pretty cheap check.
This was previously missed, though would have been diagnosed later as a requirement failure.
While here, address the FIXME in `canParseTypeSimpleOrComposition` and only check to see if we can parse a type-simple, including `each`, `some`, and `any` for better recovery.
Parse e.g `[3 x Int]` as type sugar for InlineArray. Gated behind an experimental feature flag for now.
hamishknight
force-pushed
the
inline-array-type
branch
from
3d7f28b to
dff944a
Compare
hamishknight
requested review from
mikeash,
al45tair,
rjmccall and
eeckstein
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse e.g
[3 x Int]as type sugar for InlineArray. Gated behind an experimental feature flag for now.