-
Notifications
You must be signed in to change notification settings - Fork 112
Remove the workaround for swift-package-manager-#8111. #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the workaround for swiftlang/swift-package-manager#8111. The issue has been resolved and Windows correctly exports symbols from dynamic library targets.
@swift-ci test |
@swift-ci test |
@grynspan @stmontgomery I wonder if this caused Source Compatibility Suite regressions - https://ci.swift.org/job/swift-main-source-compat-suite-debug/989/artifact/swift-source-compat-suite/ |
I suppose it's possible, but looking at the failures, they don't seem related. It looks like the testing module simply isn't being built, whereas our change here (combined with the follow-up 840c822 patch) just makes the library build as a DLL on Windows. There should be absolutely no visible change on non-Windows systems. |
I see, so it must be something about ScanDependencies or something related to that. |
I'm not willing to rule this change out entirely since the follow-up commit might have been delayed making it into a toolchain. But I would definitely look at ScanDependencies first if only to rule it out. |
Sounds good, thank you! |
Remove the workaround for swiftlang/swift-package-manager#8111. The issue has been resolved and Windows correctly exports symbols from dynamic library targets.
Checklist: