Rebase release/6.0.1 branch off release/6.0 instead of release/6.0.0. #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Explanation:** Sets the version of the library as built in CMake to "6.0". **Scope:** 6.0 releases built with CMake instead of SwiftPM **Issue:** N/A **Original PR:** #637 **Risk:** Low **Testing:** Manually tested at desk and in a toolchain build as we don't have CI jobs using CMake yet. See swiftlang/swift#76034 **Reviewer:** @compnerd @briancroom
… closures. (#643) **Explanation:** Fixes concurrency issues using `confirmation {}`, `withKnownIssue {}`, and `#expect(throws:) {}` with actor-isolated code. **Scope:** 6.0 branch (6.0.1) **Issue:** https://github.com/swiftlang/swift-integration-tests/issue/622 **Original PR:** https://github.com/swiftlang/swift-integration-tests/pull/624 **Risk:** Moderate—involves changing the signatures of a number of functions which will break ABI for them as well as potential source breakage if somebody explicitly refers to these functions by name. **Testing:** New unit test coverage. **Reviewer:** @briancroom
**Explanation:** Correctly sets `SWT_NO_EXIT_TESTS` on platforms that don't support them when building with CMake. **Scope:** Building iOS, watchOS, tvOS, visionOS, WASI from OSS. **Issue:** N/A **Original PR:** #633 **Risk:** Low **Testing:** Manually tested as we don't have CI using CMake yet. **Reviewer:** @compnerd @briancroom
…ad of a C++ macro. (#649) **Explanation:** Correctly sets the testing library version (it was failing to set on the Swift side.) **Scope:** Building with CMake **Issue:** N/A **Original PR:** #648 **Risk:** Low **Testing:** Built a toolchain and verified the string was ingested all the way through. **Reviewer:** @grynspan @briancroom
…pect()`. (#657) **Explanation:** Optimizes the implementation of `#expect()`, in particular the parts that ask for fully-qualified type names and generate `.expectationChecked` events. **Scope:** 6.0 branch **Issue:** N/A **Original PR:** #610 **Risk:** Moderate—refactors code inside `#expect()` and introduces a new lock and atomic value used by them. **Testing:** New unit test coverage, existing coverage. **Reviewer:** @briancroom @suzannaratcliff
Revert "[6.0] Reduce overhead of `.expectationChecked` event handling in `#expect()`. (#657)"
…pect()` (take 2) (#659) **Explanation:** Optimizes the implementation of `#expect()`, in particular the parts that ask for fully-qualified type names and generate `.expectationChecked` events. **Scope:** 6.0 branch **Issue:** N/A **Original PR:** #610, also includes fixup commit 6ba948a **Risk:** Moderate—refactors code inside `#expect()` and introduces a new lock and atomic value used by them. **Testing:** New unit test coverage, existing coverage. **Reviewer:** @briancroom @suzannaratcliff
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
changed the title
**Explanation:** Disables some tests that currently fail to build against the main toolchain. **Scope:** 6.0 branch **Issue:** N/A **Original PR:** #664 **Risk:** Low **Testing:** CI job run—disables existing tests **Reviewer:** @briancroom @suzannaratcliff @stmontgomery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase release/6.0.1 branch off release/6.0 instead of release/6.0.0.