Removes duplicate trivia from UnsafeExprSyntax #3043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating
UnsafeExprSyntax
, theleadingTrivia
passed as an argument fromunsafeExpr.leadingTrivia
is already included inunsafeExpr.unsafeKeyword
, which causes the trivia to be duplicated if it exists. To fix this, I modified the code to avoid passingleadingTrivia
as an argument. (Similarly, the same applies totrailingTrivia
.)I couldn’t find a suitable way to directly test
UnsafeExprSyntax
created viaOperatorTable
, so I verified the change by integrating my local modifications intoswift-format
.Please let me know if there’s a better way to test this.