-
Notifications
You must be signed in to change notification settings - Fork 440
Specify SwiftSyntax601 in more places. #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
Thanks @mbrandonw
Yes, would you be able to cherry-pick this to release/6.1 🙏? |
Also CC @keith for the bazel changes, but they look fine to me. |
Yep can do. Just so that I understand, you want me to make a new PR with these changes that targets release/6.1? |
Yep bazel changes look good! Thanks for making them! |
Yep 🙇♂️! |
@swift-ci please test |
@swift-ci please test Windows platform |
1 similar comment
@swift-ci please test Windows platform |
Thanks again @mbrandonw! |
Currently the trick of using version modules to conditionally access Swift syntax is broken for version 601:
We use these version modules heavily to support SwiftSyntax all the way back to 509, but now multiple packages in our ecosystem are broken with no way to fix them other than rolling back all SwiftSyntax support back to 600.
I believe the fix is to simply update the dependencies of SwiftSyntax to use SwiftSyntax601, but I went ahead and fixed up other inconsistencies with version modules throughout the repo. If this is the correct fix then hopefully we can get a patch release of SwiftSyntax released soon?