Enable Windows tests in GitHub Actions #2993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
enable-windows
branch
3 times, most recently
from
5b12853 to
099f141
Compare
bnbarham
reviewed
Mar 7, 2025
…LiteralValue` This matches the specification of multi-line string literal handling: From https://docs.swift.org/swift-book/documentation/the-swift-programming-language/lexicalstructure/#String-Literals: > Line breaks in a multiline string literal are normalized to use the line feed character. Even if your source file has a mix of carriage returns and line feeds, all of the line breaks in the string will be the same. From https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170417/035923.html: > The quoted string should normalize newlines to \n in the value of the literal, regardless of whether the source file uses \n (Unix), \r\n (Windows), or \r (classic Mac) line endings. Likewise, when the compiler strips the initial and final newline from the literal value, it will strip one of any of the \n, \r\n, or \r line-ending sequences from both ends of the literal.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2992
This exposed a bug in swift-syntax, which I’m fixing:
Normalize line ending to
\ninStringLiteralExprSyntax.representedLiteralValueThis matches the specification of multi-line string literal handling:
From https://docs.swift.org/swift-book/documentation/the-swift-programming-language/lexicalstructure/#String-Literals:
From https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20170417/035923.html: