Skip to content

[5.9] fix wrong diagnostic for wrong pattern #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2023
Merged

[5.9] fix wrong diagnostic for wrong pattern #1687

merged 1 commit into from
May 23, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 22, 2023

  • Explanation: If there was two identifiers with a space between, followed by a colon and a type, the parser didn't suggest a fix-it to merge them, neither did it show the correct diagnostic.
  • Scope: Swift parser and diagnostics
  • Risk: Low
  • Testing: Added correct test cases
  • Issue: N/A
  • Reviewer: @ahoppen on Fix wrong diagnostic parse typed pattern #1580

@kimdv kimdv requested a review from bnbarham May 22, 2023 11:46
@kimdv kimdv requested a review from ahoppen as a code owner May 22, 2023 11:46
ahoppen
ahoppen approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe because this only touches an error recovery branch.

@ahoppen
Copy link
Member

ahoppen commented May 22, 2023

@swift-ci Please test

@kimdv kimdv merged commit 77e4aa4 into swiftlang:release/5.9 May 23, 2023
@kimdv kimdv deleted the kimdv/cherry-pick-fix-wrong-diagnostic-for-wrong-pattern branch May 23, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimdv @ahoppen @bnbarham