Replace fish's deprecated . command with source command #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish's . command is deprecated and it's just an alias of source command. https://fishshell.com/docs/current/cmds/source.html#description
kkebo
requested review from
0xTim,
alexandersandberg,
davelester,
daveverwer,
dempseyatgithub,
kaishin,
shahmishal,
timsneath and
federicobucchi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced fish's deprecated
.command withsourcecommand in the installation instructions.Motivation:
fish's
.command is deprecated and it's just an alias ofsourcecommand. Moreover, according to the following documentation,.command is planned to be removed in the future version of fish.https://fishshell.com/docs/current/cmds/source.html#description
Modifications:
.withsourcein the instructions for fish.withsourcein the instructions for fishResult:
Users will no longer need to use deprecated commands when installing Swift.