Skip to content

Add analytics to the new base layout #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add analytics to the new base layout #1059

merged 1 commit into from
Jun 5, 2025

Conversation

shahmishal
Copy link
Member

No description provided.

Copy link
Member

@alexandersandberg alexandersandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: #18 🥲

@shahmishal shahmishal merged commit 0560240 into main Jun 5, 2025
6 of 7 checks passed
@shahmishal shahmishal deleted the add-analytics branch June 5, 2025 16:39
Copy link
Contributor

@davelester davelester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this appear before or after landing.js?

@alexandersandberg
Copy link
Member

Should this appear before or after landing.js?

Good question. The analytics script does not seem to have a large impact (see below), but it would probably be better to kick off landing.js first anyway.

CleanShot 2025-06-05 at 18 46 01

@shahmishal
Copy link
Member Author

#1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants