-
Notifications
You must be signed in to change notification settings - Fork 49
java2swift: add non-optional-returning as
function to JavaClassMacro
#74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gave this another look, it's not right at all I think. Only the known to be safe target types should be non-optional. So we need to know which types the java type extends/implements and for those types generate the method. |
as
function to JavaClassMacro
as
function to JavaClassMacro
to `JavaClassMacro` - enhance the docs
- slight modification to docs
Seems this actually passes on |
Of course! |
Cool, this is looking good now. I'd love to see perhaps another PR where we take some type that inherits from some other |
Thanks for your contrib! |
Could you please Guide me to where I should implement this? |
You're welcome! Glad I could help. |
closes #20