Skip to content

Split the Java2Swift tool out into a library target and add a test harness #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

DougGregor
Copy link
Member

Introduce a test harness so we can run the Java-to-Swift API translator against a Java class and then check the generated syntax. We could definitely do better with the diff'ing of lines to make it a little easier to use, but it's better than no testing.

…rness

Introduce a test harness so we can run the Java-to-Swift API translator
against a Java class and then check the generated syntax. We could
definitely do better with the diff'ing of lines to make it a little
easier to use, but it's better than no testing.
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm tho the lib suffix in target name is weird imho, id leave it off

.executableTarget(
name: "Java2Swift",
.target(
name: "Java2SwiftLib",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the “lib” suffix tbh, just java2swift is fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to rename the executable target to drop the Lib suffix

@DougGregor DougGregor merged commit b8ee12c into swiftlang:main Oct 11, 2024
9 of 11 checks passed
@DougGregor DougGregor deleted the java2swift-split branch October 11, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants