Skip to content

Regenerate JavaKit Swift sources now that we have support for static fields #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

DougGregor
Copy link
Member

No description provided.

@DougGregor
Copy link
Member Author

@jrosen081 FYI, this is the result of re-running the JavaKit generation now that your static field support has landed.

Copy link
Contributor

@jrosen081 jrosen081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Is the plan to always commit these every time we add more support or in the future have the first step to using this be run the make (or Gradle when the Makefile gets removed)?

@DougGregor
Copy link
Member Author

This is awesome! Is the plan to always commit these every time we add more support or in the future have the first step to using this be run the make (or Gradle when the Makefile gets removed)?

We should commit these every time we add more support, since we need them there to build the Java2Swift tool itself. It's also a nice validation step.

@DougGregor DougGregor merged commit f7b4587 into swiftlang:main Oct 11, 2024
9 of 10 checks passed
@DougGregor DougGregor deleted the javakit-regenerate branch October 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants