SwiftArena and invoking destroy on objects as arena is destroyed #67

ktoso · 2024-10-11T12:04:03Z

Work in progress.

This will eventually allow us to bound lifetimes with a SwiftArena and sanitize that we don't "leak" objects in native by retaining them longer than intended.

SwiftKit/src/main/java/org/swift/swiftkit/SwiftValueWitnessTable.java

Makefile

ktoso · 2024-10-11T15:53:37Z

Samples/SwiftKitSampleApp/src/main/java/com/example/swift/HelloJava2Swift.java

 import org.swift.swiftkit.SwiftKit;
-
+import org.swift.swiftkit.SwiftValueWitnessTable;


Moved some functionality out of SwiftKit, keeping it for things end users might wanna use.

ktoso · 2024-10-11T15:56:39Z

SwiftKit/src/test/java/org/swift/swiftkit/SwiftRuntimeMetadataTest.java

+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+public class SwiftRuntimeMetadataTest {


made these into tests rather than just one off prints in main()

SwiftKit/src/main/java/org/swift/swiftkit/util/PlatformUtils.java

ktoso · 2024-10-16T05:50:10Z

Heh I don't understand why the Java/Linux crash, local linux build is happy. I'll have to revisit this later

ktoso · 2024-10-18T13:36:47Z

Un-reproducible issues in CI which now manifest as hangs, quite a kerfuffle but I'll figure it out.

ktoso · 2024-10-20T04:27:53Z

So this reproduces only specifically in when running github actions, including using act so at least there's some hope to reproduce the issue. But it's pretty mysterious what's up with that.

ktoso · 2024-10-22T04:44:21Z

Specifically x86 has some issue with the witness table call and we just hang on:

   java.lang.Thread.State: RUNNABLE
        at java.lang.invoke.LambdaForm$MH/0x00007f25c31e6400.invoke(java.base@22.0.2/LambdaForm$MH)
        at java.lang.invoke.LambdaForm$MH/0x00007f25c31e8800.invokeExact_MT(java.base@22.0.2/LambdaForm$MH)
        at jdk.internal.foreign.abi.DowncallStub/0x00007f25c31e6800.invoke(java.base@22.0.2/Unknown Source)
        at java.lang.invoke.LambdaForm$DMH/0x00007f25c31e6c00.invokeStaticInit(java.base@22.0.2/LambdaForm$DMH)
        at java.lang.invoke.LambdaForm$MH/0x00007f25c31e7c00.invoke(java.base@22.0.2/LambdaForm$MH)
        at java.lang.invoke.LambdaForm$MH/0x00007f25c31e8000.invokeExact_MT(java.base@22.0.2/LambdaForm$MH)
        at org.swift.swiftkit.SwiftValueWitnessTable.destroy(SwiftValueWitnessTable.java:221)
        at org.swift.swiftkit.SwiftHeapObjectCleanup.run(SwiftMemoryResourceCleanup.java:37)
        at org.swift.swiftkit.ConfinedSwiftMemorySession$ConfinedResourceList.cleanup(SwiftArena.java:140)
        at org.swift.swiftkit.ConfinedSwiftMemorySession.close(SwiftArena.java:104)
        at org.swift.swiftkit.SwiftArenaTest.arena_releaseClassOnClose_class_ok(SwiftArenaTest.java:50)

trying to debug on a linux amd64 host, we'll see if I can find out what's up

It's useful to keep the exact same pattern everywhere as it's so repetetive code.

Previously this was just in a hello world app.

…dule

…rks on arm macs

ktoso · 2024-10-22T07:34:48Z

I disabled the hanging test on x86_64 so we can revisit it, I don't have good ideas what might cause that right now. We'll have to dig deeper into it specifically. It's logged as: #97

Unblocking other progress by merging this for now though.

ktoso commented Oct 11, 2024

View reviewed changes

SwiftKit/src/main/java/org/swift/swiftkit/SwiftValueWitnessTable.java Show resolved Hide resolved

ktoso commented Oct 11, 2024

View reviewed changes

SwiftKit/src/main/java/org/swift/swiftkit/SwiftValueWitnessTable.java Show resolved Hide resolved

ktoso force-pushed the wip-arenas branch from 981c09c to 961266e Compare October 11, 2024 15:37

ktoso commented Oct 11, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

ktoso commented Oct 11, 2024

View reviewed changes

SwiftKit/src/main/java/org/swift/swiftkit/util/PlatformUtils.java Show resolved Hide resolved

ktoso requested a review from DougGregor October 11, 2024 15:57

ktoso marked this pull request as draft October 11, 2024 15:57

ktoso force-pushed the wip-arenas branch 4 times, most recently from 0ec066b to bb48895 Compare October 16, 2024 04:08

ktoso changed the title ~~[WIP] Work in progress on SwiftArena and invoking destroy on objects as arena is destroyed~~ SwiftArena and invoking destroy on objects as arena is destroyed Oct 16, 2024

ktoso marked this pull request as ready for review October 16, 2024 04:10

ktoso force-pushed the wip-arenas branch 2 times, most recently from 29225bc to aa988b1 Compare October 18, 2024 09:55

ktoso marked this pull request as draft October 22, 2024 04:43

ktoso removed the request for review from DougGregor October 22, 2024 04:43

ktoso force-pushed the wip-arenas branch from ee3e424 to e062f22 Compare October 22, 2024 04:43

ktoso added 6 commits October 22, 2024 14:45

SwiftKit: use inner-static class pattern for DESC/ADDR/HANDLE constants

6b64073

It's useful to keep the exact same pattern everywhere as it's so repetetive code.

progress towards SwiftArena which manages swift values and heap objects

c802914

introduce tests for metadata size etc

ce04978

Previously this was just in a hello world app.

avoid explicitly loading libs; they can be loaded by the generated mo…

f968343

…dule

add a default toString to imported heap objects

27895d3

work in progress on calling destroy of a class

18e7f94

ktoso and others added 10 commits October 22, 2024 14:46

pass the self pointer through another pointer indirectly to destroy

18ad313

fix passing wtable to destroy

97c2eac

cleanup

6ca633c

remove un-necessary loadLibrary with dylib

0d15c84

Fix constructor test

079a6d2

remove not used LockedState

8fddb7f

debugging CI, unsure why crash happens, probably paths

92d11ee

Discard changes to Sources/JavaKitVM/LockedState.swift

5669314

debugging linux x86 issue

db8fc4f

Disable test on linux/amd64 until we figure it out, in meantime it wo…

0f60bff

…rks on arm macs

ktoso force-pushed the wip-arenas branch from e062f22 to 0f60bff Compare October 22, 2024 06:58

ktoso added 2 commits October 22, 2024 16:09

license ignore generated java files

74076aa

ignore generated jextract files, we dont commit them anymore

fa6a5b8

ktoso marked this pull request as ready for review October 22, 2024 07:33

ktoso merged commit bc54194 into swiftlang:main Oct 22, 2024
11 checks passed

ktoso deleted the wip-arenas branch October 22, 2024 07:34

ktoso mentioned this pull request Oct 22, 2024

SwiftArena type to support managing lifetimes of Swift objects from Java #35

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

SwiftArena and invoking destroy on objects as arena is destroyed #67

SwiftArena and invoking destroy on objects as arena is destroyed #67

Uh oh!

ktoso commented Oct 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ktoso Oct 11, 2024

Uh oh!

ktoso Oct 11, 2024

Uh oh!

Uh oh!

ktoso commented Oct 16, 2024

Uh oh!

ktoso commented Oct 18, 2024

Uh oh!

ktoso commented Oct 20, 2024

Uh oh!

ktoso commented Oct 22, 2024 •

edited

Loading

Uh oh!

ktoso commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

		import org.swift.swiftkit.SwiftKit;

		import org.swift.swiftkit.SwiftValueWitnessTable;

SwiftArena and invoking destroy on objects as arena is destroyed #67

SwiftArena and invoking destroy on objects as arena is destroyed #67

Uh oh!

Conversation

ktoso commented Oct 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ktoso Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

ktoso Oct 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ktoso commented Oct 16, 2024

Uh oh!

ktoso commented Oct 18, 2024

Uh oh!

ktoso commented Oct 20, 2024

Uh oh!

ktoso commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktoso commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

ktoso commented Oct 22, 2024 •

edited

Loading