[JExtract/JNI] Add support for classes/structs as parameters and return values #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rintaro As I refactored the code to match the way FFM does things, with |
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaBindingsPrinting.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
ktoso
reviewed
Jul 22, 2025
ktoso
reviewed
Jul 22, 2025
ktoso
reviewed
Jul 22, 2025
Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+NativeTranslation.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Jul 22, 2025
There was a problem hiding this comment.
Overall looks good to me! I did have some small nitpicks here and there. @rintaro could you also give it a look? This duplicates some small types the FFM side used, but maybe this way we'll be able to head towards converging them a bit... rather than do it all right away 🤔
ktoso
approved these changes
Jul 22, 2025
| @@ -110,7 +110,7 @@ extension JNISwift2JavaGenerator { | |||
| // so we pass the pointer. | |||
| return NativeResult( | |||
| javaType: .long, | |||
| conversion: .getJNIValue(.allocateSwiftValue(name: "_result", swiftType: swiftResult.type)) | |||
| conversion: .getJNIValue(.allocateSwiftValue(name: "result", swiftType: swiftResult.type)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for passing in classes/structs as parameters to functions and returning them as well. All functions now generate both a public "user-facing" Java method and a native method that is called from that. Any classes are passed as pointers and returned as pointers.
I also refactored quite a bit of the internal code to make it match the FFM style more, this should make it easier to understand and contribute to both modes.