CI: Correct validation & bring back pointer "max" bounds workaround #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jun 25, 2025
| @@ -1,5 +1,8 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
| set -x | |||
There was a problem hiding this comment.
duh! we missed those
ktoso
commented
Jun 25, 2025
| echo -e "${BOLD}SwiftPM${RESET} build..." | ||
| swift build || exit | ||
| echo -e "${BOLD}Missing ${CI_VALIDATE_SCRIPT} file!${RESET}" | ||
| exit | ||
| fi |
There was a problem hiding this comment.
Yeah let's just have each file be explicit about how it validates instead...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @rintaro bringing back the workaround for the ADDRESS bounds.
I'll look into the real solution here though, to properly size things when we use a pointer.