Skip to content

[jextract] Remove NominalTypeResolution #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 30, 2025

This is a part of #236 plus some simple test cases for SwiftLookupTable.

NominalTypeResolution was used only used for populating the SwiftLookupTable and resolving the extended type name for extensions. However SwiftLookupTable already has that capabilities (with some modifications)

Instead, use SwiftSymbolTable mechanism.
@rintaro rintaro requested review from ktoso and DougGregor May 30, 2025 03:52
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@@ -14,9 +14,13 @@

import SwiftSyntax

///// A syntax node for a nominal type declaration.
@_spi(Testing)
public typealias NominalTypeDeclSyntaxNode = any DeclGroupSyntax & NamedDeclSyntax & WithAttributesSyntax & WithModifiersSyntax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah interesting combo :)

@rintaro rintaro merged commit c7e5f12 into swiftlang:main May 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants