Skip to content

Update Class Layout to use Runtime Metadata #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions Sources/JExtractSwift/Swift2JavaTranslator+Printing.swift
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ extension Swift2JavaTranslator {
)
printer.print("")

// Layout of the class
printClassMemoryLayout(&printer, decl)

printer.print("")

// Initializers
for initDecl in decl.initializers {
printClassConstructors(&printer, initDecl)
Expand Down Expand Up @@ -264,9 +269,6 @@ extension Swift2JavaTranslator {
printClassConstants(printer: &printer)
printTypeMappingDecls(&printer)

// Layout of the class
printClassMemoryLayout(&printer, decl)

body(&printer)
}
}
Expand Down Expand Up @@ -384,12 +386,9 @@ extension Swift2JavaTranslator {
}

private func printClassMemoryLayout(_ printer: inout CodePrinter, _ decl: ImportedNominalType) {
// TODO: make use of the swift runtime to get the layout
printer.print(
"""
private static final GroupLayout $LAYOUT = MemoryLayout.structLayout(
SWIFT_POINTER
).withName("\(decl.swiftTypeName)");
private static final GroupLayout $LAYOUT = (GroupLayout) SwiftValueWitnessTable.layoutOfSwiftType(TYPE_METADATA.$memorySegment());

public final GroupLayout $layout() {
return $LAYOUT;
Expand Down
65 changes: 65 additions & 0 deletions Tests/JExtractSwiftTests/ClassPrintingTests.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2024 Apple Inc. and the Swift.org project authors
// Licensed under Apache License v2.0
//
// See LICENSE.txt for license information
// See CONTRIBUTORS.txt for the list of Swift.org project authors
//
// SPDX-License-Identifier: Apache-2.0
//
//===----------------------------------------------------------------------===//

import JExtractSwift
import Testing

struct ClassPrintingTests {
let class_interfaceFile =
"""
// swift-interface-format-version: 1.0
// swift-compiler-version: Apple Swift version 6.0 effective-5.10 (swiftlang-6.0.0.7.6 clang-1600.0.24.1)
// swift-module-flags: -target arm64-apple-macosx15.0 -enable-objc-interop -enable-library-evolution -module-name MySwiftLibrary
import Darwin.C
import Darwin
import Swift
import _Concurrency
import _StringProcessing
import _SwiftConcurrencyShims

public class MySwiftClass {
public init(len: Swift.Int, cap: Swift.Int)

public func helloMemberFunction()

public func makeInt() -> Int

@objc deinit
}
"""

@Test("Import: class layout")
func class_layout() throws {
let st = Swift2JavaTranslator(
javaPackage: "com.example.swift",
swiftModuleName: "__FakeModule"
)

try assertOutput(st, input: class_interfaceFile, .java, expectedChunks: [
"""
public static final SwiftAnyType TYPE_METADATA =
new SwiftAnyType(SwiftKit.swiftjava.getType("__FakeModule", "MySwiftClass"));
public final SwiftAnyType $swiftType() {
return TYPE_METADATA;
}


private static final GroupLayout $LAYOUT = (GroupLayout) SwiftValueWitnessTable.layoutOfSwiftType(TYPE_METADATA.$memorySegment());
public final GroupLayout $layout() {
return $LAYOUT;
}
"""
])
}
}