build: add proper search path for Windows #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows includes are under `win32` at least with the Oracle JDK. This is required to be able to build on Windows.
|
Thanks for the fix, there's probably some Thanks! |
|
We don't do Windows CI yet but we could soon, are you planning on some more work here? |
|
Yes, I'm planning on continuing some additional work here for exposing Java to Swift. |
|
Ok, awesome! Let's get the repo into shape to support windows then :-) Sorry for the delay, I'll get CI green tomorrow and merge all such pending PRs. Since we use nightly toolchain it regressed us accidentally |
|
Thanks @compnerd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows includes are under
win32at least with the Oracle JDK. This is required to be able to build on Windows.