Skip to content

JavaKit: make JavaVirtualMachine(adoptingJVM:) public #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

lhoward
Copy link
Contributor

@lhoward lhoward commented Nov 7, 2024

This is useful for a shared object to wrap a VM passed in JNI_OnLoad()

@ktoso
Copy link
Collaborator

ktoso commented Nov 7, 2024

Please remove the Sources/JavaKit/.JavaObject+Inheritance.swift.swp file, maybe add swp files to gitignore while at it?

@lhoward
Copy link
Contributor Author

lhoward commented Nov 7, 2024

Ugh sorry. How did that happen. Will fix.

@lhoward lhoward force-pushed the lhoward/public-adopt branch from f8003a2 to bdbfd42 Compare November 7, 2024 10:38
Copy link
Collaborator

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok to me

This is useful for a shared object to wrap a VM passed in JNI_OnLoad()
@lhoward lhoward force-pushed the lhoward/public-adopt branch from bdbfd42 to abdd950 Compare November 7, 2024 10:50
@ktoso ktoso merged commit 651cc89 into swiftlang:main Nov 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants