Add placeholder ordo-benchmark and JMH benchmarks #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Oct 29, 2024
ktoso
reviewed
Oct 29, 2024
ktoso
reviewed
Oct 29, 2024
helmetcrest
commented
Oct 30, 2024
ktoso
reviewed
Oct 31, 2024
| .product(name: "JavaKitNetwork", package: "swift-java"), | ||
| .product(name: "Benchmark", package: "package-benchmark"), | ||
| ], | ||
| path: "Benchmarks/JavaApiCallBenchmarks", |
There was a problem hiding this comment.
Cool structure is looking good now
ktoso
reviewed
Oct 31, 2024
| $(BUILD_DIR)/jextract/ExampleSwiftLibrary/MySwiftLibrary.swiftinterface; \ | ||
| swift run jextract-swift \ | ||
| --package-name org.swift.swiftkit.generated \ | ||
| --swift-module SwiftKitSwift \ | ||
| --output-directory ${SAMPLES_DIR}/SwiftKitSampleApp/src/generated/java \ | ||
| --output-directory ${SAMPLES_DIR}/SwiftKitSampleApp/build/generated/sources/jextract/main \ |
|
This all looks excellent, thank you! I only added a small note into the readme how to run the benchmarks :) |
|
I have now included building (not running) the benchmarks in CI as well so we don't regress them by accident. |
|
heh compiling swift benchmarks crashes on linux. I'll disable them in CI for now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only one sample benchmark for each system at the moment, so as to keep the PR scope in check.
There are a couple of known issues:
gradlew jmh.swift package benchmarkfails with aSIL verification failed: Two variables with different type but same scope!exception in the compiler. I can attach some logs if that'd be useful.I'm not sure if this PR is too early to merge, but I'd very much appreciate pointers on how to address either the above issues, or anything else that seems unusual in my PR. For instance, my formatter keeps trying to fix indents; if that's too noisy, I can manually remove them for now and open a follow-up PR.
I can confirm that everything passes
act pull_request, at least, but I needed to add a dependency onjemallocin order to build the Swift benchmarking tool.