SwiftArena.ofAuto() which uses GC to manage swift instances (and destroy them) #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Oct 29, 2024
ktoso
commented
Oct 29, 2024
SwiftKit/src/main/java/org/swift/swiftkit/ConfinedSwiftMemorySession.java
Show resolved
Hide resolved
ktoso
added a commit
to ktoso/swift-java
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
SwiftArena.ofAuto()which uses phantom references (and aCleaner) to manage java swift wrapper classes on the java side.Usage is something like this:
When the JVM no longer has references to such object, it will initiate the clean of the object. Currently this is going to destroy() the object, however in this mode we should perhaps just decrement the reference count of the underlying object for swift classes, unlike in the Confined case.